Merged
Conversation
mikhailUshakoff
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens “permissionless” documentation and improves runtime observability by adjusting error messages in the Shasta L1 submission path and expanding what the permissionless node logs for its configuration.
Changes:
- Adjust error mapping in Shasta proposal transaction building / submission to include more descriptive failure messages.
- Expand
permissionlessconfigDisplayoutput (logged at startup) to include additional fields. - Add a
permissionless/README.mddescribing the current status and related repos/branches; bump workspace version to1.33.15.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| shasta/src/l1/proposal_tx_builder.rs | Changes error mapping for propose-tx building steps. |
| shasta/src/l1/execution_layer.rs | Changes error mapping in send_batch_to_l1 around tx building and nonce retrieval. |
| permissionless/src/utils/config.rs | Expands Config’s Display output used in startup logging. |
| permissionless/README.md | Adds documentation for the “permissionless” implementation status and related branches/images. |
| Cargo.toml | Bumps workspace version to 1.33.15. |
| Cargo.lock | Updates workspace crate versions to 1.33.15. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional small improvements to error messages