Feat/matrix folding #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avor Feat/matrix folding nicks flavor
-> Fixed an small issue where we were passing a ci in matrix that wasnt needed -> Added test for correct re_prime -> Added tests for mova_matrix variant of ptvsline
Added test for the evaluation + Fixed bugs in ptvsline
NiDimi
requested changes
Jan 30, 2025
Collaborator
NiDimi
left a comment
NiDimi
left a comment
There was a problem hiding this comment.
Left a few comments. Also, let me know what you think but we should open an issue about implementing a check check_evaluation for the mova_matrix.
NiDimi
approved these changes
Jan 31, 2025
Collaborator
NiDimi
left a comment
NiDimi
left a comment
There was a problem hiding this comment.
Latest changes look good
cupicmarko
approved these changes
Feb 5, 2025
cupicmarko
left a comment
cupicmarko
left a comment
There was a problem hiding this comment.
I don't have anything specific to add, the code looks good, the comments are really useful, and the only thing might be missing is that some branches with failures are not tested, nothing else.
| } | ||
|
|
||
| pub fn verify( | ||
| fn verify( |
There was a problem hiding this comment.
I think not all of the branches are tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learning Models"