Feat/update compute_h function #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
compute_handcompute_h2functions in thepointvsline.rsfile.These functions iteratively fold multiple polynomials until a single one is computed as result.
The original implementation used
DensePolynomialfor the inner computations, which is fine. But for large MLEs this causes excessive allocations and intermediate objects that are soon discarded.This PR makes 2 significant changes:
DensePolynomialstruct, we work over the coefficients of the polynomials directly.This approach seems to be fine, I have compared the results against the original implementation (you can do this by replacing the
compute_hfunction with the original implementation). I have also extended the tests cases for thetest_compute_h2_comparetest function.Results:
cargo bench --bench mova_matrixto test it. I tried size 16 and 512.