Added benchmark tests for Mova_Matrix implementation #7
Conversation
| // Right now we are packing the 4 matrices in a single vector to achieve compatibility with NIFStrait. | ||
| fn new_witness(abce: Vec<C::ScalarField>, e_len: usize, _rng: impl RngCore) -> Self::Witness { | ||
| fn new_witness(abce: Vec<C::ScalarField>, e_len: usize, _rng: impl RngCore) -> Witness<C> { |
There was a problem hiding this comment.
Since we don't need to be compatible with the trait anymore, this should be updated
There was a problem hiding this comment.
Besides this, I think the PR it's ready. But we should either tag the older implementation that implemented the trait, or keep this modified version on a different branch.
There was a problem hiding this comment.
Removed the _rng and I created the branch compatible_sonobe_version. I think it makes more sense as a branch since we might want to continue working on it in the future
There was a problem hiding this comment.
@NiDimi Besides the _rng variable, I also meant the fact that we are passing abce as a single vector. I think each one should be a different variable, since we are no longer constrained on the number of parameters.
|
#8 Adds all the changes here along with the inclusion of Matrex. Let's just keep this branch however so we can see differences in times between the original implementation and the refactored one. |
-> As part of the benchmark tests I had to remove the compatibility with Sonobe (e.g. the R1CS carry overs) to avoid adding too much useless code