Remove (::ConnectionRule)(src, dst, t) fallback method; make discrete_event_condition on connections take src / dst args.#44
Merged
MasonProtter merged 2 commits intomasterfrom Oct 25, 2025
Conversation
…nnections take src / dst
…nd dst subsystems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the following breaking API updates:
(cr::ConnectionRule)(src, dst, t) = cr(src, dst)which was added previously to avoid breakage when we made connection rules take a time argument in addition to thesrcanddstsubsystems. The presence of this method was a bit of a annoying crutchdiscrete_event_conditionfrom just(conn, t)to(conn, t, sys_src, sys_dst)so that events can trigger based off information in the source or destination subsystems as wellhas_discrete_eventsfrom just(typeof(conn),)for connection events to(typeof(conn), get_tag(src), get_tag(dst)), i.e. it now also can depend on the types of the source and dest subsystemsevent_timesfrom just(conn,)to(conn, sys_src, sys_dst)for connection events.cc @vyudu