fix: mark NamedPipeServer inline definitions#15
Merged
NewYaroslav merged 3 commits intomainfrom Oct 28, 2025
Merged
Conversation
Add inline qualifiers to NamedPipeServer member implementations in the .ipp file so multiple translation units can include the header without emitting duplicate definitions.
Add a helper script that compiles the ODR reproduction sources and links them together using the stub Windows header.
Add a GitHub Actions job that builds the ODR regression test sources using the helper script so CI catches duplicate-definition regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ff400619e88328b9165c4e3e810ce2