chore: simplify reward distribution code#66
Merged
mfontanini merged 5 commits intomainfrom Feb 3, 2026
Merged
Conversation
jimouris
approved these changes
Feb 3, 2026
Comment on lines
+30
to
+31
| checked_at: u64, | ||
| synced_at: u64, |
Member
There was a problem hiding this comment.
What is this, block number? seconds? I'll derive it from the context later on but might be helpful to have a comment or rename to something more descriptive.
Member
Author
There was a problem hiding this comment.
Will fix in next PR, need to fix something
| cache.last_budget = Some(fetched); | ||
| cache.last_remaining = None; | ||
| let ctx = self.fetch_token_context(reward_address).await?; | ||
| if ctx.checked_at != block_timestamp { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the reward distribution since it was pretty convoluted and hard to follow. Specifically this:
KeeperStateit lives inside the reward distributor. This avoids having tolockevery time we want to deal with it.tracing::instrumentto avoid repeating the same parameters when logging.Options around this info and keeps directly theu64andU256to avoid dealing with options since there was no need for them.