-
Notifications
You must be signed in to change notification settings - Fork 40
[ANDROID][AGENTS] Fix example app build #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be re-formatted.
| ```bash | ||
| python3 coreruntime/scripts/gen_python_ast.py \ | ||
| agents/notifications_summarizer/delitepyAssets/main.py \ | ||
| && mv "${_%.py}.ast" agents/examples/android/app/src/main/assets/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, $_ here may make it difficult for the reader to understand what's going on.
| Open this directory in Android Studio. | ||
|
|
||
| 3. **Sync and Build** | ||
| 5. **Sync and Build** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the trailing space in this line intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If yes, you can replace the trailing (double space) with a \.
Co-authored-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai> Signed-off-by: Naman Anand <46650369+void-memories@users.noreply.github.com>
Co-authored-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai> Signed-off-by: Naman Anand <46650369+void-memories@users.noreply.github.com>
Description
Please provide a description of this PR.
Fixes # (issue)
#99
Checklist: