Skip to content

Conversation

@void-memories
Copy link
Contributor

@void-memories void-memories commented Jul 21, 2025

Description

Please provide a description of this PR.

Fixes # (issue)
#99

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Has user-facing changes. This may include API or behavior changes and performance improvements, etc

Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
@void-memories void-memories requested review from a team, jpuneet and nrjpoddar as code owners July 21, 2025 09:46
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
Signed-off-by: Naman Anand <naman.anand@nimbleedgehq.ai>
@ultajain ultajain added the ready-for-test This label triggers android instrumentation tests label Jul 21, 2025
@nrjpoddar nrjpoddar removed the ready-for-test This label triggers android instrumentation tests label Jul 21, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be re-formatted.

```bash
python3 coreruntime/scripts/gen_python_ast.py \
agents/notifications_summarizer/delitepyAssets/main.py \
&& mv "${_%.py}.ast" agents/examples/android/app/src/main/assets/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, $_ here may make it difficult for the reader to understand what's going on.

Open this directory in Android Studio.

3. **Sync and Build**
5. **Sync and Build**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing space in this line intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If yes, you can replace the trailing (double space) with a \.

jpuneet and others added 3 commits July 25, 2025 05:19
Signed-off-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Co-authored-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Naman Anand <46650369+void-memories@users.noreply.github.com>
Co-authored-by: Puneet Jindal <puneet.jindal@nimbleedgehq.ai>
Signed-off-by: Naman Anand <46650369+void-memories@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants