git-instafix: init at 0.2.1

[mightyiam]

Description of changes

This app seems nice. Here's a package for everyone!

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3125

[jfly]

[rjpcasalino]

Result of nixpkgs-review pr 275402 run on x86_64-linux 1

1 package built:

• git-fixup

[nix-shell:~/.cache/nixpkgs-review/pr-275402/results/git-fixup/bin]$ ./git-fixup --version
git-fixup 0.1.8

[kuruczgy]

Could you talk a bit about this particular git-fixup project (link)? It is made mostly by a single author, with the last commit from more than a year ago. Contrast this with https://github.com/keis/git-fixup, which seems to be receiving semi-regular updates, with multiple contributors.

I would propose either

• switching to https://github.com/keis/git-fixup unless you depend on some specific feature of this rust version,
• or renaming this to something else, so that if someone in the future wants to package https://github.com/keis/git-fixup, it can get the git-fixup name.

[mightyiam]

Author considering renaming their project. I'd give them some more time.

[kuruczgy]

It seems that the author renamed the project, did a new release with the new name, and even provided a description of what differentiates it from the shell-based version I linked, so from my side this can go ahead 👍 (As long as you adjust the PR with the new name and the new version of course.)

[mightyiam]

Made all the updates.

[kuruczgy]

LGTM, just minor formatting nitpicks.

[kuruczgy]

Ideally we should ask the author to make the git binary configurable. But for the first version this should be fine.

[kuruczgy]

Nitpick: unnecessary trailing comma.

[kuruczgy]

meta should be at the very bottom, at least that's what I see in most packages.

[mightyiam]

Applied feedback.

[pbsds]

Result of nixpkgs-review pr 275402 run on x86_64-linux 1

1 package built:

• git-instafix

Ofborg darwin seem to be failing due to a linker error, consider marking it meta.broken = stdenv.isDarwin

[pbsds]

still broken on darwin

[pbsds]

Suggested change

	description = "Quickly fix up an old commit using your currently-staged changes.";
	description = "Quickly fix up an old commit using your currently-staged changes";

[mightyiam]

Thank you!