teleport_15: init at 15.2.2, teleport_12: remove

[justinas]

Description of changes

Adding Teleport 15, a new major version.

Removing Teleport 12, because it is effectively EOL as the upstream only officially supports the 3 latest major versions at any given time.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[justinas]

Teleport changed the license to AGPLv3 (or later) staring with version 15. https://goteleport.com/blog/teleport-oss-switches-to-agpl-v3/

[justinas]

I am not sure how to make the by-name check happy given multiple versions living in teleport/14 teleport/15 etc.

[infinisil]

The pkgs/by-name only requires new packages to use it, and that is based on whether the new definition looks like <attr> = callPackage ..., which is the case here.

Since there's a generic.nix file used by all the versions, you're a bit more restricted in what you can do, but there's some options:

• My recommendation: Avoid pkgs/by-name for now by creating a package set for all versions, either like this:

    teleportVersions = callPackages ../servers/teleport { };
    inherit (teleportVersions) teleport_14 teleport_15 teleport;

  Or if you don't want to expose teleportVersions to users:

    inherit (callPackages ../servers/teleport { })
      teleport_14 teleport_15 teleport;

  • There's a bug in the pkgs/by-name check that would still complain about this, see tests.nixpkgs-check-by-name: Syntactic callPackage detection and allow new package variants #285089, but this would be allowed

    Now fixed!

• Alternatively, expose generic.nix as pkgs.teleportGeneric, such that you can refactor the individual versions to use pkgs/by-name, each of which taking teleportGeneric as an argument:

  { teleportGeneric }:
  teleportGeneric { ... }

[justinas]

Thanks for the advice @infinisil , I ended up utilizing callPackages and the check passes now.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3614

[SuperSandro2000]

Can you rebase? otherwise LGTM

[justinas]

Rebased.

[tomberek]

Result of nixpkgs-review pr 285922 run on x86_64-linux 1

2 packages blacklisted:

• nixos-install-tools
• tests.nixos-functions.nixos-test

6 packages built:

• teleport (teleport_15)
• teleport.client (teleport_15.client)
• teleport_13
• teleport_13.client
• teleport_14
• teleport_14.client