Skip to content

Conversation

@drawbu
Copy link
Member

@drawbu drawbu commented May 12, 2024

ZHF: #309482

Description of changes

Upstream was using depreacted module imp. Replaced with importlib.
Appiled a patch from this pr: benoitc/http-parser#101

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 12, 2024
@drawbu
Copy link
Member Author

drawbu commented May 12, 2024

Result of nixpkgs-review pr 311123 run on x86_64-linux 1

4 packages built:
  • python311Packages.http-parser
  • python311Packages.http-parser.dist
  • python312Packages.http-parser
  • python312Packages.http-parser.dist

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 12, 2024
@drawbu drawbu added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 12, 2024
Co-authored-by: annaleeleaves <168274788+annaleeleaves@users.noreply.github.com>
@drawbu drawbu force-pushed the fix-http-parser branch from 42a9451 to ed0e732 Compare May 12, 2024 19:47
drupol
drupol previously requested changes May 12, 2024
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the PR title.

@fpletz fpletz changed the title Fix http parser python312Packages.http-parser: fix build May 12, 2024
@fpletz fpletz dismissed drupol’s stale review May 12, 2024 22:37

We don't have a policy on PR titles

@fpletz fpletz merged commit 0d793f3 into NixOS:master May 12, 2024
@drawbu drawbu deleted the fix-http-parser branch May 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants