active record 7 #45
Merged
active record 7 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelglass
force-pushed
the
active_record-7
branch
from
51da379 to
71b696a
Compare
michaelglass
force-pushed
the
active_record-7
branch
from
d294e5e to
7e2f2f0
Compare
michaelglass
commented
Apr 1, 2025
| iterator.new(ff).each do |tname, label, row| | ||
| conn.insert_fixture(row, tname) | ||
| @label_to_id[label] = conn.send(:last_inserted_id, tname) unless label == NO_LABEL | ||
| last_inserted_id = conn.insert(conn.send(:build_fixture_sql, Array.wrap(row), tname)) |
Contributor
Author
There was a problem hiding this comment.
rails 7 drops sqlite-specific last_inserted_id and the old API was invalid
|
I had trouble figuring out how the authentication works for that script. That said, maybe it would be quicker for you to give it a go. Here's the branch with rails 7.0 already setup: https://github.com/NoRedInk/NoRedInk/pull/51365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@derek-noredink upgraded this to support active record 7 as far as I can tell
can you test this against the monolith (using AR 7) and see if it still works?
the commands in the monolith are ...
./script/export_live_fixtures.shto test building the fixtures andrake db:resetto test importing the fixturescontributes to https://linear.app/noredink/issue/FXN-3849/upgrade-rails-to-72