Proper redis-cluster MGET & MSET by being aware of hash tags#178
Open
eoghanmurray wants to merge 1 commit intoNoneGG:masterfrom
Open
Proper redis-cluster MGET & MSET by being aware of hash tags#178eoghanmurray wants to merge 1 commit intoNoneGG:masterfrom
eoghanmurray wants to merge 1 commit intoNoneGG:masterfrom
Conversation
…h slots (which determines that all keys go to the same cluster node)
9f23f46 to
1491595
Compare
Contributor
Author
|
Just now realise that there is some similar prior work on this:
This is embodied in the following logic: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #177
This is a fix for the non-use of MGET & MSET when in redis-cluster mode.
We (carefully) examine the keys to determine which can be grouped together as they use the same hash tag and hence go to the same slot.