Skip to content

optimize redis cluster readonly mode #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexezio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

optimize redis cluster readonly mode #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec6257
optimize: optimize cluster readonly mode by avoid moved in write com…
Mar 15, 2021
6c00bc0
Update pool.py
alexezio Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aredis/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ async def execute_command(self, *args, **kwargs):
# MOVED
node = self.connection_pool.get_master_node_by_slot(slot)
else:
node = self.connection_pool.get_node_by_slot(slot)
node = self.connection_pool.get_node_by_slot(slot, command)
r = self.connection_pool.get_connection_by_node(node)

try:
Expand Down
5 changes: 3 additions & 2 deletions aredis/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,8 @@ def get_connection_by_node(self, node):
def get_master_node_by_slot(self, slot):
return self.nodes.slots[slot][0]

def get_node_by_slot(self, slot):
if self.readonly:
def get_node_by_slot(self, slot, command=None):
#prevent movederr exception, optimized read lookup speed
if self.readonly and command in ["GET", "GETBIT", "HGETALL", "HMGET", "HLEN", "LLEN", "LINDEX", "MGET"]:
return random.choice(self.nodes.slots[slot])
return self.get_master_node_by_slot(slot)