Conversation
gotta test this on my linux vm
Owner
Author
|
To further increase performance we can pipe the frames directly to chafa but trying to do it multithreaded would be a bit complicated could try doing single threaded ffmpeg -> pipe image to chafa --> write frame to folder |
Owner
Author
Owner
Author
|
fixed it, the issue was with the HEIGHT variable not being updated in main thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




On my VM it gives roughly a 3x speed improvement for caching
Using a threadpoolexecutor, for each frame a thread is used (for chafa and some simple data processing).
ffmpeg is still singlethreaded
ffmpeg is set to extract jpg instead of png now.
a new argument called --quality was added
its between 2(high quality) and 10(low quality)
this should provide significant performance improvement at no visible ascii output loss.