Skip to content

nvdash: clamp cursor row/column to prevent out-of-range errors #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachMahan64 wants to merge 2 commits into
base: v3.0
Choose a base branch
from
Open

nvdash: clamp cursor row/column to prevent out-of-range errors #512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ddf68
clamp cursor in nvdash to prevent crash
zachMahan64 Sep 6, 2025
e169d4f
clamp key movements
zachMahan64 Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions lua/nvchad/nvdash/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,17 @@ M.open = function(buf, win, action)
vim.wo[win].virtualedit = "all"

if key_lines[1] then
api.nvim_win_set_cursor(win, { key_lines[1].i, key_lines[1].col })
local row = key_lines[1].i
local col = key_lines[1].col

local line = api.nvim_buf_get_lines(buf, row - 1, row, false)[1] or ""
if col > #line then
col = #line
elseif col < 0 then
col = 0
end

api.nvim_win_set_cursor(win, { row, col })
end

local key_movements = function(n, cmd)
Expand All @@ -200,10 +210,20 @@ M.open = function(buf, win, action)
if cmd and x.cmd then
vim.cmd(x.cmd)
else
return { x.i, x.col }
local line = api.nvim_buf_get_lines(buf, x.i - 1, x.i, false)[1] or ""
local col = math.max(0, math.min(x.col, #line))
return { x.i, col }
end
end
end

if key_lines[1] then
local line = api.nvim_buf_get_lines(buf, key_lines[1].i - 1, key_lines[1].i, false)[1] or ""
local col = math.max(0, math.min(key_lines[1].col, #line))
return { key_lines[1].i, col }
end

return { 1, 0 }
end

map({ "k", "<up>" }, function()
Expand Down