feat: Add identity module to test-utils and migrate objects-identity tests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests
Add Tier 1 (identity) module to objects-test-utils and completely migrate
objects-identity tests to use shared utilities. No backward compatibility
stubs - clean migration.
## objects-test-utils changes:
**New identity module:**
- RandomPasskeyIdentity / RandomWalletIdentity structured types
- test_identity_id() - Returns canonical test identity (obj_2dMiYc8RhnYkorPc5pVh9)
- random_passkey_identity() - Generate random P-256 identity
- random_wallet_identity() - Generate random secp256k1 identity
**Testing:**
- 7 new integration tests in self_test.rs
- 4 new doctests
- Total: 41 tests passing (up from 26 in PR1a)
## objects-identity changes:
**Main crate:**
- Add Handle::reserved_handles() - Expose protocol constants publicly
- Add Handle::is_reserved() - Check if handle is reserved
- Moves protocol logic from test-only code to main crate (proper location)
**Test migration:**
- integration_test.rs: Use objects_test_utils::{crypto, time, identity}
- property_test.rs: Use Handle::reserved_handles() from main crate
- Delete tests/common/mod.rs entirely (80 lines of duplication eliminated)
- All fixtures use crypto::passkey_keypair().signing_key
- All nonces use crypto::random_nonce()
- All timestamps use time::now()
**Clippy fixes:**
- Use range contains: (23..=25).contains(&len)
- Remove needless borrow: hex::encode([...].repeat(16))
- Collapse nested if with let binding
## Verification:
- objects-test-utils: 41 tests passing
- objects-identity: 63 tests passing (22 unit + 29 integration + 11 property + 1 doctest)
- Zero clippy warnings with -D warnings
- All code formatted
## Key decisions:
✅ No deprecated stubs - clean break from old test utilities
✅ Reserved handles moved to main crate (protocol logic, not test helpers)
✅ Foundation complete for PR2 (data), PR3 (transport), PR4 (sync)
Follows PR1b plan. Builds on PR1a (#15).
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Use crypto::deterministic_bytes() instead of string literal to match the robust pattern used for challenge encoding. More realistic test case that demonstrates proper byte array → hex encoding flow.
Add section on proper test data generation using deterministic_bytes() and hex encoding instead of string literals. Ensures test data mirrors production data flow (bytes → encoding).
m-005
added a commit
that referenced
this pull request
Jan 16, 2026
…tests (#16) * feat: Add identity module to test-utils and migrate objects-identity tests Add Tier 1 (identity) module to objects-test-utils and completely migrate objects-identity tests to use shared utilities. No backward compatibility stubs - clean migration. ## objects-test-utils changes: **New identity module:** - RandomPasskeyIdentity / RandomWalletIdentity structured types - test_identity_id() - Returns canonical test identity (obj_2dMiYc8RhnYkorPc5pVh9) - random_passkey_identity() - Generate random P-256 identity - random_wallet_identity() - Generate random secp256k1 identity **Testing:** - 7 new integration tests in self_test.rs - 4 new doctests - Total: 41 tests passing (up from 26 in PR1a) ## objects-identity changes: **Main crate:** - Add Handle::reserved_handles() - Expose protocol constants publicly - Add Handle::is_reserved() - Check if handle is reserved - Moves protocol logic from test-only code to main crate (proper location) **Test migration:** - integration_test.rs: Use objects_test_utils::{crypto, time, identity} - property_test.rs: Use Handle::reserved_handles() from main crate - Delete tests/common/mod.rs entirely (80 lines of duplication eliminated) - All fixtures use crypto::passkey_keypair().signing_key - All nonces use crypto::random_nonce() - All timestamps use time::now() **Clippy fixes:** - Use range contains: (23..=25).contains(&len) - Remove needless borrow: hex::encode([...].repeat(16)) - Collapse nested if with let binding ## Verification: - objects-test-utils: 41 tests passing - objects-identity: 63 tests passing (22 unit + 29 integration + 11 property + 1 doctest) - Zero clippy warnings with -D warnings - All code formatted ## Key decisions: ✅ No deprecated stubs - clean break from old test utilities ✅ Reserved handles moved to main crate (protocol logic, not test helpers) ✅ Foundation complete for PR2 (data), PR3 (transport), PR4 (sync) Follows PR1b plan. Builds on PR1a (#15). * fix: use deterministic_bytes for content_hash in test Use crypto::deterministic_bytes() instead of string literal to match the robust pattern used for challenge encoding. More realistic test case that demonstrates proper byte array → hex encoding flow. * docs: add test pattern guidance for cryptographic data Add section on proper test data generation using deterministic_bytes() and hex encoding instead of string literals. Ensures test data mirrors production data flow (bytes → encoding).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Tier 1 (identity) module to
objects-test-utilsand completely migrateobjects-identitytests to use shared utilities. This is part 2 of the test utilities consolidation effort (PR1b).Changes
New Functionality
src/identity.rs(200 lines): Identity factories with structured return typesRandomPasskeyIdentityandRandomWalletIdentitystructstest_identity_id()returns canonical "obj_2dMiYc8RhnYkorPc5pVh9"random_passkey_identity()andrandom_wallet_identity()factoriesProtocol Logic Enhancement
objects-identity/src/handle.rs: Exposed reserved handles as public APIHandle::reserved_handles()→&'static [&'static str]Handle::is_reserved(s: &str)→boolTest Migration
objects-identity/tests/integration_test.rs: Migrated all fixtures to useobjects_test_utils::cryptoobjects-identity/tests/property_test.rs: Updated to useHandle::reserved_handles()from main crateobjects-identity/tests/common/mod.rs(80 lines eliminated)Test Results
-D warningsMigration Strategy
Clean migration with no backward compatibility stubs:
tests/common/mod.rsentirelyVerification
Related