feat(objects-test-utils): Add transport module and migrate objects-transport tests (PR3) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansport tests Implements transport-layer test utilities in objects-test-utils and migrates all objects-transport tests to use the shared utilities. Changes: - Add transport.rs module with endpoint, config, and assertion utilities - Add objects-transport and tokio dependencies to test-utils - Migrate integration_test.rs to use objects_test_utils::transport - Migrate property_test.rs to remove common module dependency - Remove crates/objects-transport/tests/common/ entirely - Replace rand::rng() usage for consistency with existing patterns All tests pass (13 integration tests, 16 property tests). Related to PR3 roadmap for test utilities consolidation.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
… pattern - Migrate all 6 remaining SecretKey::generate calls in property tests to transport::secret_key() - Remove unused SecretKey import from property_test.rs - Apply direct import pattern for assert_node_ids_match in integration tests - Demonstrates recommended module-prefixed pattern (transport::endpoint()) with pragmatic exceptions for assertion helpers (assert_node_ids_match) All tests passing: 45 transport tests (16 unit + 13 integration + 16 property) Zero clippy warnings
m-005
added a commit
that referenced
this pull request
Jan 16, 2026
…ansport tests (PR3) (#17) * feat(objects-test-utils): Add transport module and migrate objects-transport tests Implements transport-layer test utilities in objects-test-utils and migrates all objects-transport tests to use the shared utilities. Changes: - Add transport.rs module with endpoint, config, and assertion utilities - Add objects-transport and tokio dependencies to test-utils - Migrate integration_test.rs to use objects_test_utils::transport - Migrate property_test.rs to remove common module dependency - Remove crates/objects-transport/tests/common/ entirely - Replace rand::rng() usage for consistency with existing patterns All tests pass (13 integration tests, 16 property tests). Related to PR3 roadmap for test utilities consolidation. * fix(objects-test-utils): Add missing Duration import to transport doctest * refactor: Complete property test migration and apply pragmatic import pattern - Migrate all 6 remaining SecretKey::generate calls in property tests to transport::secret_key() - Remove unused SecretKey import from property_test.rs - Apply direct import pattern for assert_node_ids_match in integration tests - Demonstrates recommended module-prefixed pattern (transport::endpoint()) with pragmatic exceptions for assertion helpers (assert_node_ids_match) All tests passing: 45 transport tests (16 unit + 13 integration + 16 property) Zero clippy warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements transport-layer test utilities in
objects-test-utilsand migrates allobjects-transporttests to use the shared utilities, completing PR3 from the test utilities consolidation roadmap.Changes
New
transport.rsModulenetwork_config(),network_config_with_relay())endpoint(),endpoint_with_key(),endpoint_with_config())secret_key())wait_short(),wait_medium(),wait_long())assert_node_ids_match()with#[track_caller])Migration
rand::rng()direct usage in tests → now usingtransport::secret_key()crates/objects-transport/tests/common/(no backward compatibility stubs)Test Results
✅ All tests passing:
Benefits
Roadmap Progress
Verification
Related to #13