feat(test-utils): Add data module and migrate objects-data tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive data-layer test utilities to objects-test-utils and migrate all objects-data tests to use the new foundation, eliminating 322 lines of duplicated test code. **New utilities (objects-test-utils/src/data.rs):** - Asset/Project/Reference factories with sensible defaults - SignedAsset workflows for Passkey and Wallet signers - Structured bundle types (SignedAssetPasskeyBundle, SignedAssetWalletBundle) - Proper encoding patterns: test data mirrors production (bytes → hex) **Migration:** - Rewrote integration_test.rs (36 tests) to use new utilities - Migrated property_test.rs (15 tests) to use new utilities - Deleted objects-data/tests/common/mod.rs (322 lines) - All 54 tests passing **Dependencies:** - Added sha2, base64, alloy-primitives to objects-test-utils - Added objects-data dependency for tier-2 utilities - Added objects-test-utils dev-dependency to objects-data Follows CLAUDE.md test patterns with proper encoding and battle-tested dependencies (alloy-primitives for EIP-191, RustCrypto p256/k256).
|
No issues found. Checked for bugs and CLAUDE.md compliance. |
m-005
added a commit
that referenced
this pull request
Jan 16, 2026
Add comprehensive data-layer test utilities to objects-test-utils and migrate all objects-data tests to use the new foundation, eliminating 322 lines of duplicated test code. **New utilities (objects-test-utils/src/data.rs):** - Asset/Project/Reference factories with sensible defaults - SignedAsset workflows for Passkey and Wallet signers - Structured bundle types (SignedAssetPasskeyBundle, SignedAssetWalletBundle) - Proper encoding patterns: test data mirrors production (bytes → hex) **Migration:** - Rewrote integration_test.rs (36 tests) to use new utilities - Migrated property_test.rs (15 tests) to use new utilities - Deleted objects-data/tests/common/mod.rs (322 lines) - All 54 tests passing **Dependencies:** - Added sha2, base64, alloy-primitives to objects-test-utils - Added objects-data dependency for tier-2 utilities - Added objects-test-utils dev-dependency to objects-data Follows CLAUDE.md test patterns with proper encoding and battle-tested dependencies (alloy-primitives for EIP-191, RustCrypto p256/k256).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
objects-test-utilsobjects-datatests to use new foundationobjects-data/tests/common/mod.rs(322 lines of duplication eliminated)Changes
New utilities (
objects-test-utils/src/data.rs):asset(),asset_with_hash()- Asset factories with sensible defaultsproject(),project_from_replica()- Project factoriesreference()- Reference factorysigned_asset_passkey(),signed_asset_wallet()- Complete SignedAsset workflowsSignedAssetPasskeyBundle,SignedAssetWalletBundlehex::encode(crypto::deterministic_bytes(seed))Test migration:
integration_test.rs(748 lines, 36 tests)property_test.rs(15 tests)objects-data/tests/common/mod.rs(322 lines)Dependencies:
sha2,base64,alloy-primitivestoobjects-test-utilsobjects-datadependency for tier-2 utilitiesobjects-test-utilsdev-dependency toobjects-dataTest Results
All tests passing:
Verification
Follows CLAUDE.md test patterns with battle-tested dependencies (alloy-primitives for EIP-191, RustCrypto p256/k256).