feat: Migrate sync tests to objects-test-utils foundation (PR4) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes PR4 of the test utilities consolidation plan by migrating objects-sync and objects-registry tests to use the shared test utilities foundation. This is a full migration with no backwards compatibility. **Changes:** Sync module (Tier 4): - Add sync.rs to objects-test-utils with sync_engine(), project_from_replica(), and asset() helpers - Add objects-sync and anyhow dependencies to objects-test-utils Test migrations: - Migrate objects-sync integration tests to use sync::*, identity::*, and transport::* utilities - Delete objects-sync/tests/test_utils.rs (full migration, no deprecation stubs) - Migrate objects-registry tests to use crypto::passkey_keypair().signing_key and time::now() - Clean up unused imports and helper functions Dependencies: - Add objects-test-utils dev-dependency to objects-sync and objects-registry **Verification:** - All workspace tests pass (excluding registry DB tests which require DATABASE_URL) - Code formatted with cargo fmt - Clippy passes with -D warnings Follows RFC plan: feat/test-utils-foundation → feat/test-utils-data → feat/test-utils-transport → feat/test-utils-sync
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
…ts_sync::Result Fixes semantic error handling issue where data layer validation errors were incorrectly wrapped as sync layer Iroh errors. Changes: - sync_engine(), project_from_replica(), asset() now return anyhow::Result<T> - Removed incorrect Error::Iroh wrapping of objects_data::Error - Added proper error context messages This maintains compatibility with test code using the ? operator while providing correct error semantics and better error messages.
m-005
added a commit
that referenced
this pull request
Jan 16, 2026
* feat: Migrate sync tests to objects-test-utils foundation Completes PR4 of the test utilities consolidation plan by migrating objects-sync and objects-registry tests to use the shared test utilities foundation. This is a full migration with no backwards compatibility. **Changes:** Sync module (Tier 4): - Add sync.rs to objects-test-utils with sync_engine(), project_from_replica(), and asset() helpers - Add objects-sync and anyhow dependencies to objects-test-utils Test migrations: - Migrate objects-sync integration tests to use sync::*, identity::*, and transport::* utilities - Delete objects-sync/tests/test_utils.rs (full migration, no deprecation stubs) - Migrate objects-registry tests to use crypto::passkey_keypair().signing_key and time::now() - Clean up unused imports and helper functions Dependencies: - Add objects-test-utils dev-dependency to objects-sync and objects-registry **Verification:** - All workspace tests pass (excluding registry DB tests which require DATABASE_URL) - Code formatted with cargo fmt - Clippy passes with -D warnings Follows RFC plan: feat/test-utils-foundation → feat/test-utils-data → feat/test-utils-transport → feat/test-utils-sync * fix(test-utils): Use anyhow::Result for sync helpers instead of objects_sync::Result Fixes semantic error handling issue where data layer validation errors were incorrectly wrapped as sync layer Iroh errors. Changes: - sync_engine(), project_from_replica(), asset() now return anyhow::Result<T> - Removed incorrect Error::Iroh wrapping of objects_data::Error - Added proper error context messages This maintains compatibility with test code using the ? operator while providing correct error semantics and better error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Completes PR4 of the test utilities consolidation plan by migrating objects-sync and objects-registry tests to use the shared test utilities foundation.
Full migration - no backwards compatibility or deprecation stubs.
Changes
Sync Module Implementation (Tier 4)
sync::sync_engine()- Creates SyncEngine for testingsync::project_from_replica()- Creates Project from ReplicaId using RFC-004sync::asset()- Creates Asset with Result type for test compatibilityTest Migrations
objects-sync:
create_test_sync_engine()→sync::sync_engine()test_identity_id()→identity::test_identity_id()test_project_from_replica()→sync::project_from_replica()test_asset()→sync::asset()ObjectsEndpoint::builder().bind()→transport::endpoint()crates/objects-sync/tests/test_utils.rs(full migration)objects-registry:
test_passkey_key()→crypto::passkey_keypair().signing_keytest_wallet_key()→crypto::wallet_keypair().signing_keycurrent_timestamp()→time::now()Dependencies
objects-syncandanyhowtoobjects-test-utils/Cargo.tomlobjects-test-utilsdev-dependency toobjects-sync/Cargo.tomlobjects-test-utilsdev-dependency toobjects-registry/Cargo.tomlVerification
PR Dependency Chain
Files Changed
crates/objects-test-utils/src/sync.rs(new)crates/objects-test-utils/src/lib.rscrates/objects-test-utils/Cargo.tomlcrates/objects-sync/Cargo.tomlcrates/objects-sync/tests/integration_tests.rscrates/objects-sync/tests/test_utils.rs(deleted)bins/objects-registry/Cargo.tomlbins/objects-registry/tests/integration_tests.rsbins/objects-registry/tests/concurrency_tests.rsRelated
~/.claude/plans/logical-purring-comet.md