[19.0] [MIG] document_url: Migration to 19.0 #578
Conversation
[MIG] document_url * bump version to 9.0.1.0.0 and make it installable * Update JS structure * Add css in order to be compliant with odoo style * Add a README.rst and OCA conventions * Improve selector * add fr.po for fr translation * open link with target='_blank'
Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one. With this patch, the menu item styling matches those available in all surrounding menus.
Replace char © by word Copyright Change format in usage description
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/
Currently translated at 100.0% (14 of 14 strings) Translation: knowledge-12.0/knowledge-12.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-13.0/knowledge-13.0-document_url Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/
[MIG] document_url: Migration to 14.0
Define the add attachment and add URL buttons on the same line. Allow downloading of url type attachments by clicking on the icon or the name. Define the name of the url type attachments as links (allows to open it in a new tab). Hide the download button for url attachments. Force to set mimetype to "application/link" for url attachments. Displays a link icon for url attachments. TT30263
|
/ocabot migration document_url |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Tested on runboat. Are you testing your migrations in your end before pushing them to a PR? It's not working correctly for clicking on the attachment to go to the URL:
There shouldn't preview box as well.
And finally, please squash administrative commits into the main one.
| def setUp(self): | ||
| super().setUp() | ||
| wizard_add_url = self.env["ir.attachment.add_url"] | ||
| self.user = self.env["res.users"].create( |
There was a problem hiding this comment.
Use from odoo.tests import new_test_user
BhaveshHeliconia
force-pushed
the
19.0-mig-document_url
branch
from
c21bf75 to
67af352
Compare
|
@pedrobaeza I did test the migration on my side, and at that time it was working for me. After reviewing it again, I noticed the issue occurs after refreshing the page once the link is added—most likely I missed that scenario during my initial testing. I’ve now fixed the issue and also improved the UI for a better user experience. Apologies for the inconvenience. |
|
OK, now it's working, but it seems you have copied/pasted the whole CSS. Can you reduce it with inheritance? |
BhaveshHeliconia
force-pushed
the
19.0-mig-document_url
branch
from
67af352 to
cc249b0
Compare
|
Please apply #581 (before migration commit). |
|
This PR has the |
- In a first step, instead of replacing a node content with its verbatim copy, we uses the xpath "replace" command with "$0" magic keyword to move all the <t> content into a <div>. - In a second step, the "Add URL" button is added after the existing "Attach files"button.
BhaveshHeliconia
force-pushed
the
19.0-mig-document_url
branch
from
cc249b0 to
1acc2b3
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at ffb9a21. Thanks a lot for contributing to OCA. ❤️ |
20 participants
No description provided.