[18.0][MIG] mail_inline_css: Migration to 18.0 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-12.0/social-12.0-mail_inline_css Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_inline_css/
If premailer receives an empty value, such as an empty string, on parsing, it returns None and fails when trying to call 'etree.fromstring()' on this None result. We should avoid to call premailer on an empty string, as the result will anyway not change. We may have an empty template for instance when a template could not compile due to a mistake.
The mail module offers a better hook to manipulate html: `render_post_process`. By using this, we make sure the transform is applied properly before html tags sanitizing happens, which can alter - if not screw - the final result. Finally, it simplifies code :)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-14.0/social-14.0-mail_inline_css Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_inline_css/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_inline_css Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_inline_css/
Currently translated at 100.0% (5 of 5 strings) Translation: social-16.0/social-16.0-mail_inline_css Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_inline_css/it/
nguyenminhchien
force-pushed
the
18.0-mig-mail_inline_css
branch
from
19b0c0c to
564e39f
Compare
34 tasks
hbrunn
approved these changes
Dec 27, 2024
Contributor
|
This PR has the |
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 2095d46. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email_template_qweb:mail.templatefrom core modulemailhas already supported qweb content via the fieldbody_html(https://github.com/odoo/odoo/blob/18.0/addons/mail/models/mail_template.py#L63).email_template_qweb.