-
-
Notifications
You must be signed in to change notification settings - Fork 178
[19.0][MIG] account_invoice_margin: Migration to 19.0 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Debora7
wants to merge
59
commits into
OCA:19.0
Choose a base branch
from
dakai-soft:19.0-mig-account-invoice-margin
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] README.rst [UPD] Update account_invoice_margin.pot Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-11.0/margin-analysis-11.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-11-0/margin-analysis-11-0-account_invoice_margin/es/
[UPD] README.rst
…t invoice margin security group set
[FIX] account_invoice_margin: Set purchase_price when user has not set invoice margin security group set
[REF] rename file with the name of the model [ADD] margins on account.invoice model (and related views) [ADD] description and screenshot [FIX] Typo on margin (%) field name [ADD] fr translation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-12.0/margin-analysis-12.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-account_invoice_margin/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin/es/
The invoice may be done in a currency different from the company currency, so the cost (purchase_price) amount will be incorrect in such context. TT38500
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/fr/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/fr_FR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-account_invoice_margin/es/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-17.0/margin-analysis-17.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-17-0/margin-analysis-17-0-account_invoice_margin/it/
Contributor
|
@Debora7 Please, solve pre-commit issues |
Comment on lines
+49
to
+53
| invoice.margin = margin | ||
| invoice.margin_signed = margin_signed | ||
| invoice.margin_percent = ( | ||
| price_subtotal and margin_signed / price_subtotal * 100 or 0.0 | ||
| ) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| invoice.margin = margin | |
| invoice.margin_signed = margin_signed | |
| invoice.margin_percent = ( | |
| price_subtotal and margin_signed / price_subtotal * 100 or 0.0 | |
| ) | |
| invoice.update( | |
| { | |
| "margin": margin, | |
| "margin_signed": margin_signed, | |
| "margin_percent": ( | |
| price_subtotal and margin_signed / price_subtotal * 100 if price_subtotal | |
| else 0.0 | |
| ) | |
| } | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.