Skip to content

Conversation

@kobros-tech
Copy link
Contributor

@kobros-tech kobros-tech commented Apr 2, 2025

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sebastienbeau sebastienbeau added this to the 18.0 milestone Jun 3, 2025
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch from 2064f49 to 14065cc Compare June 17, 2025 11:21
@kobros-tech
Copy link
Contributor Author

@sbidoul
@lmignon
@sebastienbeau

can we review this?

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch 6 times, most recently from 51e7643 to 44aa529 Compare September 1, 2025 17:31
@kobros-tech
Copy link
Contributor Author

@lmignon

I would add this PR: #402
but the test for wrong URL or 401 is making error in the log, I know it is intended behaviour of yours but OCA bot does know understand that.

Is there a better way you have to run that test or shall I introduce some ideas?

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch 3 times, most recently from 5c4a328 to dd26e9d Compare September 3, 2025 02:54
@kobros-tech
Copy link
Contributor Author

@lmignon

now I see there is an issue with base_rest module js and import of js files.

I saw a couple of issues, but I don't know too much about that module and it's function?

@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch 2 times, most recently from b3ee9a3 to 2685d0f Compare September 3, 2025 03:20
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch from 2685d0f to 38890ef Compare September 3, 2025 03:36
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch from 38890ef to 10379e8 Compare September 3, 2025 03:41
@kobros-tech
Copy link
Contributor Author

@lmignon

finally I fixed the issue in the other module and temporarily adding its commit here but last two commits should be deleted when we intend to merge.

Suffexing js files with .esm.js is much better to correct style and syntax.
@kobros-tech kobros-tech force-pushed the 18.0-mig-fastapi_auth_jwt_demo branch from 10379e8 to 023270b Compare September 3, 2025 22:24
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants