-
-
Notifications
You must be signed in to change notification settings - Fork 181
[19.0] [MIG] mail_environment: Migration to 19.0 #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
* Move mail_environment in root folder * Use absolute imports for openerp and new Model classes * Use cr argument instead of cursor, propagate context * Update fields, remove deprecated 'method' argument, change 'states' otherwise the fields are not readonly (seems that the 'states' of the original field is kept. * Activate the installable flag * Indentation of the view with 2 spaces * Remove only the attrs attribute instead of redefining the whole field * pep8 * crm is not a dependency for mail_environment * Fix typo in manifest
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
rename *_xml entries in manifest
[MIG] Rename manifest files
Depending on server_environment is enough
Currently translated at 100.0% (6 of 6 strings) Translation: server-env-12.0/server-env-12.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-12-0/server-env-12-0-mail_environment/pt_BR/
Currently translated at 100.0% (6 of 6 strings) Translation: server-env-17.0/server-env-17.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-17-0/server-env-17-0-mail_environment/it/
Currently translated at 100.0% (6 of 6 strings) Translation: server-env-18.0/server-env-18.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-mail_environment/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-env-18.0/server-env-18.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-mail_environment/
Currently translated at 100.0% (8 of 8 strings) Translation: server-env-18.0/server-env-18.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-mail_environment/it/
Currently translated at 62.5% (5 of 8 strings) Translation: server-env-18.0/server-env-18.0-mail_environment Translate-URL: https://translation.odoo-community.org/projects/server-env-18-0/server-env-18-0-mail_environment/fr/
…r.mail_server` model This field is used to choose the authentication method, and used by core modules `google_gmail` and `microsoft_outlook`, for example, to define their own authentication methods.
|
/ocabot migration mail_environment |
|
@rven @rousseldenis @leemannd Guys, i have found an error ! To test it you can run the runbot of this PR and just go to your user parameters, you will see an error message directly. (or go to res_users --> select a user) a problem occure because this code on the odoo core had change the logic : Odoo 19.0 code is performing a search on the field smtp_user which is not possible when having a non stored field. The field in question is https://github.com/odoo/odoo/blame/19.0/addons/mail/models/res_users.py#L136 that mean we need to override the method _compute_outgoing_mail_server_id to get out the smtp_user or find another solution. To test it you can run the runbot of this PR and just go to your user, you will see an error message directly. |
78abc9b to
9fb7434
Compare
|
@cyrilmanuel smtp_user error should be fixed! |
9fb7434 to
011eda9
Compare
|
smtp_host was giving the same issues. <record id="view_ir_mail_server_search" model="ir.ui.view">
<field name="model">ir.mail_server</field>
<field name="arch" type="xml">
<search string="Outgoing Mail Servers">
<field name="name"
filter_domain="['|', '|',
('name', 'ilike', self),
('smtp_host', 'ilike', self),
('smtp_user', 'ilike', self)]"
string="Outgoing Mail Server"/> |
FrancoMaxime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review
No description provided.