fix(worker): propagate errors instead of silently swallowing them #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All 12 handlers that were returning nil, nil on error now properly return the error with context. This ensures errors are logged by the dispatcher instead of being silently ignored, making debugging much easier. Affected handlers: - handleSoldierState - handleVehicleState - handleFiredEvent - handleProjectileEvent - handleHitEvent - handleKillEvent - handleChatEvent - handleRadioEvent - handleFpsEvent - handleAce3DeathEvent - handleAce3UnconsciousEvent - handleMarkerMove
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All 12 handlers that were returning
nil, nilon error now properly return the error with context. This ensures errors are logged by the dispatcher instead of being silently ignored.Problem
Handler errors were being swallowed with
return nil, nil, making it impossible to debug issues like the capture frame parsing failures that caused empty position arrays in recordings.Affected handlers
Test plan