fix(worker): cache entities when using memory backend #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the root cause of empty positions in recordings.
When using the memory storage backend, entities were only stored in the backend's internal map but NOT in
EntityCache. State handlers useEntityCache.GetSoldier()to look up entities, causing all state updates to fail with "soldier X not found in cache".Root Cause Analysis
handleNewSoldiercallsm.backend.AddSoldier()→ stores in memory backend's maphandleSoldierStatecallss.deps.EntityCache.GetSoldier()→ EntityCache is empty!Fix
Now entities are always cached in EntityCache regardless of storage backend:
Test plan