Skip to content

Conversation

@fank
Copy link
Member

@fank fank commented Feb 2, 2026

Summary

  • Add actual storage for :NEW:TIME:STATE: command (previously just acknowledged)
  • Record mission time synchronization data: frame, system time, mission date, time multiplier, mission time
  • Add TimeState model to core, GORM, and conversion layer
  • Implement RecordTimeState in memory backend and storage interface

Test plan

  • All existing tests pass
  • Build succeeds
  • Test with live Arma 3 mission recording

fank added 2 commits February 2, 2026 17:48
Add actual storage for the :NEW:TIME:STATE: command which records mission
time synchronization data (frame, system time, mission date, time multiplier,
mission time). Previously this was just acknowledged without storing.
Improve test coverage for the TimeState implementation.
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Merging this branch changes the coverage (1 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/OCAP2/extension/v5/cmd/ocap_recorder 0.00% (ø)
github.com/OCAP2/extension/v5/internal/handlers 1.21% (-0.03%) 👎
github.com/OCAP2/extension/v5/internal/model 0.00% (ø)
github.com/OCAP2/extension/v5/internal/model/convert 14.99% (+0.14%) 👍
github.com/OCAP2/extension/v5/internal/model/core 0.00% (ø)
github.com/OCAP2/extension/v5/internal/storage 0.00% (ø)
github.com/OCAP2/extension/v5/internal/storage/memory 16.18% (+0.04%) 👍
github.com/OCAP2/extension/v5/internal/worker 1.77% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/OCAP2/extension/v5/cmd/ocap_recorder/main.go 0.00% (ø) 0 0 0
github.com/OCAP2/extension/v5/internal/handlers/handlers.go 1.21% (-0.03%) 9355 (+256) 113 9242 (+256) 👎
github.com/OCAP2/extension/v5/internal/model/convert/convert.go 14.99% (+0.14%) 874 (+12) 131 (+3) 743 (+9) 👍
github.com/OCAP2/extension/v5/internal/model/core/events.go 0.00% (ø) 0 0 0
github.com/OCAP2/extension/v5/internal/model/model.go 0.00% (ø) 473 (+13) 0 473 (+13)
github.com/OCAP2/extension/v5/internal/storage/memory/memory.go 16.73% (+0.04%) 1518 (+50) 254 (+9) 1264 (+41) 👍
github.com/OCAP2/extension/v5/internal/storage/storage.go 0.00% (ø) 0 0 0
github.com/OCAP2/extension/v5/internal/worker/worker.go 0.94% (ø) 635 6 629

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/OCAP2/extension/v5/internal/handlers/handlers_test.go
  • github.com/OCAP2/extension/v5/internal/model/convert/convert_test.go
  • github.com/OCAP2/extension/v5/internal/storage/memory/memory_test.go
  • github.com/OCAP2/extension/v5/internal/worker/dispatch_test.go

@fank fank merged commit 47df1dd into main Feb 2, 2026
3 checks passed
@fank fank deleted the feat/implement-time-state branch February 2, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants