Skip to content

fix: align parser with old extension data format #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fank merged 3 commits into from
Feb 2, 2026
Merged

fix: align parser with old extension data format #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
839405d
fix: align parser with old extension data format
fank Feb 2, 2026
7af8d03
test: add coverage for old extension data formats
fank Feb 2, 2026
83d0c49
test: increase coverage for parser_v1.go to 100%
fank Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/storage/converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,20 @@ func stringToSide(s string) pbv1.Side {
}
}

// sideIndexToSide converts a side index to protobuf Side enum
// Old extension uses BIS_fnc_sideID: -1=global, 0=EAST, 1=WEST, 2=RESISTANCE, 3=CIVILIAN
func sideIndexToSide(idx int) pbv1.Side {
switch idx {
case 0:
return pbv1.Side_SIDE_WEST
case 1:
return pbv1.Side_SIDE_EAST
case 1:
return pbv1.Side_SIDE_WEST
case 2:
return pbv1.Side_SIDE_GUER
case 3:
return pbv1.Side_SIDE_CIV
case -1:
return pbv1.Side_SIDE_GLOBAL
default:
return pbv1.Side_SIDE_UNKNOWN
}
Expand Down
7 changes: 4 additions & 3 deletions internal/storage/converter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,17 +521,18 @@ func TestConverter_StringToSide(t *testing.T) {
}

func TestSideIndexToSide(t *testing.T) {
// Old extension uses BIS_fnc_sideID: -1=global, 0=EAST, 1=WEST, 2=RESISTANCE, 3=CIVILIAN
tests := []struct {
name string
input int
want pbv1.Side
}{
{"WEST index 0", 0, pbv1.Side_SIDE_WEST},
{"EAST index 1", 1, pbv1.Side_SIDE_EAST},
{"EAST index 0", 0, pbv1.Side_SIDE_EAST},
{"WEST index 1", 1, pbv1.Side_SIDE_WEST},
{"GUER index 2", 2, pbv1.Side_SIDE_GUER},
{"CIV index 3", 3, pbv1.Side_SIDE_CIV},
{"UNKNOWN index 4", 4, pbv1.Side_SIDE_UNKNOWN},
{"UNKNOWN negative", -1, pbv1.Side_SIDE_UNKNOWN},
{"GLOBAL negative", -1, pbv1.Side_SIDE_GLOBAL},
{"UNKNOWN large", 100, pbv1.Side_SIDE_UNKNOWN},
}

Expand Down
Loading
Loading