Merged
Conversation
memalhot
force-pushed
the
gpu_class
branch
4 times, most recently
from
55c27ca to
45a2bde
Compare
Collaborator
|
This is a good start! Left some inline comments. In addition, could you rename the |
DanNiESh
requested changes
Aug 20, 2025
memalhot
force-pushed
the
gpu_class
branch
3 times, most recently
from
d3009e9 to
9f7fcff
Compare
DanNiESh
reviewed
Aug 26, 2025
memalhot
force-pushed
the
gpu_class
branch
3 times, most recently
from
7be0378 to
f07ee65
Compare
…int to clusterqueues, and observability for jobs through rolebinding
DanNiESh
approved these changes
Aug 29, 2025
gpu-class/clusterqueue_rb.yaml
Outdated
| resources: ["clusterqueues"] | ||
| verbs: ["get", "list", "watch"] | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 |
Collaborator
There was a problem hiding this comment.
I'd move this rolebinding to rb.yaml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting up for new gpu class by creating notebooks for students to use, setting up localqueue so they can submit gpu jobs, and setting up rolebindings so students can see what nodes are using gpus, what jobs are running, etc