webhook: use cert-manager for self-signed cert#28
Merged
Conversation
jtriley
requested review from
DanNiESh,
IsaiahStapleton,
computate and
larsks
larsks
reviewed
Nov 14, 2025
Contributor
Author
|
This is active on ocp-test and, as far as I can tell, it's still functioning as intended. I added myself to the |
IsaiahStapleton
approved these changes
Nov 18, 2025
Collaborator
IsaiahStapleton
left a comment
IsaiahStapleton
left a comment
There was a problem hiding this comment.
lgtm, tested and working
jtriley
force-pushed
the
assign-class-label-tls
branch
2 times, most recently
from
f90e1df to
8637510
Compare
Contributor
Author
|
@IsaiahStapleton I just updated the README to remove the instructions about generating certificates given that this will fix that issue. Mind taking another look? Thanks! |
This patch uses the cert-manager operator to automatically generate the self-signed CA, cert, and key and mount it within the webhook deployment. It also uses cert-manager to inject the CA cert into the mutatatingwebhookconfiguration.
jtriley
force-pushed
the
assign-class-label-tls
branch
from
8637510 to
03f0cda
Compare
Collaborator
|
@jtriley Update to the README looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch uses the cert-manager operator to automatically generate the self-signed CA, cert, and key and mount it within the webhook deployment. It also uses cert-manager to inject the CA cert into the mutatatingwebhookconfiguration.
In theory this should allow us to fully automate the webhook deployment via argocd. Currently testing this on ocp-test.