"Fix" PERFORM bounds check in 4.x - but disable it for now as it is not ISO-compliant#194
"Fix" PERFORM bounds check in 4.x - but disable it for now as it is not ISO-compliant#194ddeclerck wants to merge 1 commit intoOCamlPro:gc4from
Conversation
GitMensch
left a comment
There was a problem hiding this comment.
please change those two warnings to an error and adjust the testsuite - in general this disabling is exactly the right thing and also should ease later merges
b964c7f to
bf523b0
Compare
GitMensch
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
bf523b0 to
2ae8aa8
Compare
|
I guess that's it ? |
2ae8aa8 to
8de1114
Compare
|
Thanks again - time for upstream trunk, then going on with the 3x->trunk merge. It would be nice if you find the time to finish #191 by backporting this adjustment (which then has a misleading title). |
Actually I might as well add a ChangeLog entry for those changes (especially those in
I'll add those changes to #191 but I'll let someone else deal with the "other stuff" that remain to be addressed in that PR.
Well at first it was just about disabling the PEFORM bound check, hence the title. |
8de1114 to
5c503a6
Compare
|
@ddeclerck I'm confused - what is the state of this PR? |
This one has been merged already (to trunk, revision 5358). |
As per #147 (comment).