Allow inspect with or conditions#262
Allow inspect with or conditions#262emilienlemaire wants to merge 2 commits intoOCamlPro:gnucobol-3.x-mf-aixfrom
or conditions#262Conversation
emilienlemaire
added
the
MF-AIX
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
commenting as it isn't a draft...
Please always start with the testcases Here you want a syntax/extension one for the dialect option (seems like that is really only mf-strict.conf allowing it, default and lax would with a warning as it does not conflict with anything) - and of course for each place where after-before-ohrase is applicable also a test case compiling with -finspect-or=ok.
as soon as doing the first change create a Changelog entry - this way you've documented what you did already and don't need to think about it later (which is especially useful when coming back to a change later or if someone takes over),
cobc/parser.y
Outdated
| } | ||
| | BEFORE _initial inspect_or_list | ||
| { | ||
| cb_verify(cb_inspect_or, _("INSPECT or")); |
There was a problem hiding this comment.
that string does not need a translation as both INSPECT and OR reference keywords; you possibly can improve that string in any case
|
Hi Simon! |
|
What would be the better workaround to do in standard GnuCOBOL to do the same thing without INSPECT OR ? Because for me, if there is no better workaround, it should be enabled by default so that everybody can use it, no ? |
3 participants
Allow inspect with
orconditions in inspect region, wheninspect-with-ordialect support is enabled