Fix #389 by removing parentheses in CTAS with ORDER BY on InterSystems IRIS#390
Merged
schuemie merged 4 commits intoOHDSI:developfrom Oct 13, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #390 +/- ##
========================================
Coverage 79.74% 79.74%
========================================
Files 5 5
Lines 395 395
========================================
Hits 315 315
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
schuemie
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes #389 , which highlights an issue with InterSystems IRIS not supporting specific use of parentheses in
CREATE TABLE AS SELECTstatements using anORDER BYby adding a rewrite rule that removes the offending parentheses.I also added a simple unit test to validate this rewrite rule.