feat: added retrieval of file type fields#41
Open
ChrisAt2at wants to merge 3 commits intoOOlashyn:masterfrom
Open
feat: added retrieval of file type fields#41ChrisAt2at wants to merge 3 commits intoOOlashyn:masterfrom
ChrisAt2at wants to merge 3 commits intoOOlashyn:masterfrom
Conversation
ChrisAt2at
commented
Jul 26, 2024
ChrisAt2at
commented
- Extracted retrieval of note attachments to separate function
- Introduced isAttachmentPdf member to determine PDF type once per file
- inverted conditional logic on isAttachmentPdf not to use negation
- Added function to retrieve any file type fields. Quickest way to prevent large code refactoring was to convert the file blob to Base64 string
- Bumbed version to .2
- Extracted retrieval of note attachments to separate function - Introduced isAttachmentPdf member to determine PDF type once per file - inverted conditional logic on isAttachmentPdf not to use negation - Added function to retrieve any file type fields. Quickest way to prevent large code refactoring was to convert the file blob to Base64 string - Bumbed version to .2
…name - We notices Dynamics sometimes uses octet-stream mimetype for png/jpg/jpeg images and PDF files in file columns - First version had hardcoded logicalname+s for plural name (for download API). Now we use the MetaData API to get it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.