Update CONTRIBUTING.md#319
Merged
PhilipFackler merged 2 commits intoPhilipFackler/print-monitored-varsfrom Dec 19, 2025
Merged
Conversation
Collaborator
|
I'm surprised you're removing the guideline altogether. I would think we would want enum value formatting to be consistent across the project, even if the style should be different from what this section says. |
Collaborator
Author
Updated guidelines for |
7d2bcd1
into
PhilipFackler/print-monitored-vars
6 checks passed
PhilipFackler
pushed a commit
that referenced
this pull request
Dec 19, 2025
* Update CONTRIBUTING.md * Add specific guidelines for enums
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove style guidelines for
enums because we are already making exceptions for enums entering the JSON parser.@superwhiskers
Proposed changes
For now, just remove style guidelines for enums.
Checklist
N/A