Initial formatting with clang format file#32
Closed
alexander-novo wants to merge 3 commits intoadd-clang-formatfrom
Closed
Initial formatting with clang format file#32alexander-novo wants to merge 3 commits intoadd-clang-formatfrom
alexander-novo wants to merge 3 commits intoadd-clang-formatfrom
Conversation
Closed
pelesh
reviewed
Dec 9, 2024
ComponentLib/PowerElectronics/DistributedGenerator/DistributedGenerator.cpp
Outdated
Show resolved
Hide resolved
pelesh
reviewed
Dec 9, 2024
Comment on lines
21
to
23
| InductionMotor<ScalarT, IdxT>::InductionMotor( | ||
| IdxT id, ScalarT Lls, ScalarT Rs, ScalarT Llr, ScalarT Rr, ScalarT Lms, ScalarT RJ, ScalarT P) | ||
| : Lls_(Lls), Rs_(Rs), Llr_(Llr), Rr_(Rr), Lms_(Lms), RJ_(RJ), P_(P) |
Collaborator
There was a problem hiding this comment.
Can we configure formatting of functions with many arguments and initialization in constructor like below? It spans more lines of code but it is clearer and let you add comments for each variable, if necessary.
Suggested change
| InductionMotor<ScalarT, IdxT>::InductionMotor( | |
| IdxT id, ScalarT Lls, ScalarT Rs, ScalarT Llr, ScalarT Rr, ScalarT Lms, ScalarT RJ, ScalarT P) | |
| : Lls_(Lls), Rs_(Rs), Llr_(Llr), Rr_(Rr), Lms_(Lms), RJ_(RJ), P_(P) | |
| InductionMotor<ScalarT, IdxT>::InductionMotor(IdxT id, // explanation what this variable is | |
| ScalarT Lls, | |
| ScalarT Rs, | |
| ScalarT Llr, | |
| ScalarT Rr, | |
| ScalarT Lms, | |
| ScalarT RJ, | |
| ScalarT P) | |
| : Lls_(Lls), | |
| Rs_(Rs), | |
| Llr_(Llr), | |
| Rr_(Rr), | |
| Lms_(Lms), | |
| RJ_(RJ), | |
| P_(P) |
Collaborator
Author
There was a problem hiding this comment.
It is already set such that If you were to add a comment to one of the lines as shown, then the formatter will format as shown.
alexander-novo
force-pushed
the
format-all
branch
from
b3ff2c6 to
badffc3
Compare
Collaborator
Author
|
Files which require some manual overriding of autoformatting:
|
alexander-novo
force-pushed
the
format-all
branch
from
4a1cde5 to
0ac489c
Compare
This was referenced Feb 17, 2025
Closed
Collaborator
|
Closing in favor of #68. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only minimally edited some files manually, such as
PowerSystemData.hpp