Merged
Conversation
These functions never access object state - they should have been static anyways. This allows `const` functions in Ida to call these functions.
Steven-Roberts
requested changes
Jan 7, 2026
Collaborator
Steven-Roberts
left a comment
There was a problem hiding this comment.
@Steven-Roberts let me know if there's anything else you think I should put in.
This looks like a reasonable set of stats to start with.
pelesh
approved these changes
Jan 9, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
A couple of minor things to fix before this could be merged, otherwise very helpful. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new structure,
IdaStats, which keeps track of several statistics returned by IDA. A user can query these statistics from IDA by callingIda::getStats()and can accumulate several runs of stats in the structure. There is also functionality to print a report, similar to theIda::printFinalStats()function after the stats have been accumulated together.Closes #322
@Steven-Roberts let me know if there's anything else you think I should put in.
Proposed changes
It makes sense for
Ida::getStats()to beconst, but thenIda::checkAllocation()andIda::checkOutput()are inaccessible. These functions never touch any IDA state, so it makes sense for these functions to bestaticanyway.Checklist
-Wall -Wpedantic -Wconversion -Wextra.There are not unit tests, but I have added a printout of the report to the
rlcircuitexample:Further comments