Skip to content

Additional Enzyme examples and use cases (e.g DistributedGenerator)#54

Merged
pelesh merged 57 commits intodevelopfrom
nicholson/enzyme-usecase
Feb 27, 2025
Merged

Additional Enzyme examples and use cases (e.g DistributedGenerator)#54
pelesh merged 57 commits intodevelopfrom
nicholson/enzyme-usecase

Conversation

@nkoukpaizan
Copy link
Collaborator

@nkoukpaizan nkoukpaizan commented Feb 11, 2025

nkoukpaizan and others added 30 commits February 3, 2025 13:02
Co-authored-by: pelesh <peles2@llnl.gov>
@nkoukpaizan nkoukpaizan self-assigned this Feb 11, 2025
@nkoukpaizan nkoukpaizan changed the title Additional Enzyme example and use case for DistributedGenerator Additional Enzyme examples and use cases (e.g DistributedGenerator) Feb 11, 2025
@pelesh
Copy link
Collaborator

pelesh commented Feb 19, 2025

If you have time, feel free to start adding some suggestions. This is going to be a long PR.

Perhaps we should consider breaking this into a series of PRs, each with very specific focus?

@nkoukpaizan
Copy link
Collaborator Author

Perhaps we should consider breaking this into a series of PRs, each with very specific focus?

I agree. It's getting harder to keep this branch up to date with develop as well.

@nkoukpaizan nkoukpaizan marked this pull request as ready for review February 20, 2025 14:49
@nkoukpaizan
Copy link
Collaborator Author

I marked the PR as ready for review. I will create other PRs for the next features.

Copy link
Collaborator

@shakedregev shakedregev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left mentions on some variable names that should be changed throughout.
There are no comments on any of the test functions.
Code passes all tests, so I approved it.

Copy link
Collaborator

@reid-g reid-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some code style issues still need to be addressed.

@pelesh pelesh merged commit c3d86e6 into develop Feb 27, 2025
2 checks passed
pelesh added a commit that referenced this pull request Apr 14, 2025
)

* Add preliminary Enzyme support

* Use better naming conventions

* More verbose tests for enzyme support.

* int --> double in Enzyme examples.

* Separate scalar and vector examples using Enzyme.

* Use classes in EnzymeLibCheck.

* Basic usage of DenseMatrix in EnzymeVector example.

* Method to convert Dense matriz to COO.

* Use DenseMatrix to store the Jacobians in Enzyme vector example.

* Working Enzyme derivative of DistributedGenerator

* EnzymeLibVectorCheck.

* Better documentation of the DenseMatrix class.

---------

Co-authored-by: Asher Mancinelli <ashermancinelli@gmail.com>
Co-authored-by: pelesh <peles2@llnl.gov>
Co-authored-by: Slaven Peles <peless@ornl.gov>
@nkoukpaizan nkoukpaizan deleted the nicholson/enzyme-usecase branch May 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants