fix(slicing): fix settings mesh alignment for angled slicing#97
Merged
liamnwhite1 merged 3 commits intodevelopfrom Dec 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the cross-sectioning and skeleton region processing logic to ensure consistent alignment, simplify interfaces, and improve debug traceability. The main changes include updating the cross-section function to optionally preserve input shifts for mesh alignment, propagating this alignment through the buffered slicer and settings geometry, and refactoring skeleton region methods to use internal state for layer tracking and debugging.
Cross-sectioning and mesh alignment improvements
doCrossSectionfunction incross_section.handcross_section.cppnow accepts apreserve_input_shiftparameter, allowing multiple meshes to share the same flattening transform when slicing with an angled plane. This ensures consistent alignment of settings and build geometry. [1] [2] [3] [4]computeSettingsPolygonsmethod inbuffered_slicer.handbuffered_slicer.cppnow takes abase_shiftparameter, propagating the primary mesh's shift to settings geometry for proper alignment in 2D space. Geometry is translated if needed to match the base shift. [1] [2] [3]Skeleton region refactoring and debug improvements
Skeletonregion class now stores the current layer number internally (m_layer_num) and uses it for debugging and geometry cleaning, replacing previous method signatures that passed the layer number as a parameter. This change affectssimplifyInputGeometry,inspectSkeleton, and related debug output. [1] [2] [3] [4] [5] [6] [7] [8] [9]Minor interface and documentation updates
These changes collectively improve the reliability and maintainability of cross-sectioning and region processing, especially when handling complex multi-mesh slicing scenarios.