add option to merge/include all traces within requested time bounds#211
Merged
add option to merge/include all traces within requested time bounds#211
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to merge multiple traces within requested time bounds when calling get_acoustic_data_LF. Previously, only the first trace was returned when data was broken up by diversions, potentially excluding the majority of available data.
- Added
merge_tracesparameter (default=False) to control merging behavior - Implemented warning message when multiple traces exist but merge_traces=False
- Added trace merging logic with sampling rate normalization for EarthScope data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jdduprey
force-pushed
the
LF-trace-handling
branch
from
441956c to
261bbcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
get_acoustic_data_LFinstantiates Hydrophone data object like this:HydrophoneData(data_stream[0].data, data_stream[0].stats, node). If the data has been broken up by diversions this means the majority of the data can be excluded if there are multiple traces.I've added an option to include all merged traces within the time bounds, along with a printed warning if you're using the default behavior and there are multiple traces.