-
Notifications
You must be signed in to change notification settings - Fork 0
Budget App #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Budget App #2
Conversation
Feat/create test
danielufeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ol-create ,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
Highlights
- Nice commits messages✔️
- Descriptive PR ✔️
- Clean Code✔️
- Clean Design ✔️
Suggested changes
- Nice work done on your project, as a requirement kindly record a 5-minute video presenting the features of the project, the video should contain a clear and objective description of your project in professional English, a demo of your project, highlighting all the project feature, a highlight about a piece of the code you find interesting or are proud of making.
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
README.md
Outdated
|
|
||
| ## 🚀 Live Demo <a name="live-demo"></a> | ||
|
|
||
| > [Live Demo Link](https://blog-app-rails.herokuapp.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nice work deploying your app to Heroku, kindly check the demo link redirects to the default Heroku page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there 👋,
I have some technical issues with my machine.
This affect the quality of the presentation. I will fix the problem later and redo the presentation, thanks.
rotimiazeez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ol-create 👏🏽,
Your project is complete! There is nothing else to say other than... it's time to merge it ![]()
Congratulations! 🎉
Highlights
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code. Some of them were simply missed by the previous reviewer, and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me(@rotimiazeez) in your question so I can receive the notification.
As described in the Code reviews limits policy, you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
Hi there 👋,
Project requirements
Design
Original design idea by Gregoire Vella on Behance.
The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.
Interactions
Splash screen
Sign up and log in pages
Home page (catagories page)
Transactions page
"Add a new category" page
"Add a new transaction" page
Testing requirements
Technical requirements