Fixes #issue8 - SizeChunker is not wating for chunkStart to finish before running _finishChunk#9
Open
kksharma1618 wants to merge 2 commits intoOlegas:masterfrom
Open
Fixes #issue8 - SizeChunker is not wating for chunkStart to finish before running _finishChunk#9kksharma1618 wants to merge 2 commits intoOlegas:masterfrom
kksharma1618 wants to merge 2 commits intoOlegas:masterfrom
Conversation
Author
|
Ran unit test after the fix. Worked.
|
lib/size-chunker.js
Outdated
Owner
There was a problem hiding this comment.
May be we need to swap order here? Now we can get finishChunk event for chunk N after startChunk for N+1
Author
|
:) sorry i missed that part. what do you think now? |
Owner
|
Now it is totally broken... Deeper refactoring is required here. We need to split |
Author
|
Ok. Thanks for looking into it. Nice lib btw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #8