Refactor: extract duplicated code and reorder tests#143
Merged
elliot-100 merged 2 commits intoOlen:mainfrom Aug 2, 2024
Merged
Refactor: extract duplicated code and reorder tests#143elliot-100 merged 2 commits intoOlen:mainfrom
elliot-100 merged 2 commits intoOlen:mainfrom
Conversation
…roup()` to non-public `Spond._get_entity()'
elliot-100
changed the title
Collaborator
Author
|
I think best if I merge this as is, as it should make other fixes and improvements easier. Any objections? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
refactors out common code from
Spond.get_event()andSpond.get_group()methods to a non-publicSpond._get_entity()method.@dhomeier note that I have not yet touched the similar event lookup in
update_event(), I know you are looking at this method in your Fixupdate_eventsfor nonexistent IDs and support creation of new events #134.refactors the
Spondtest suite into separate classes for Event, Group and export related methods.I may add more (which is why the heading is so general), so will keep this in draft for now.