refactor: apply several optimizations#2
Merged
notigorwastaken merged 16 commits intoOnBeat-Project:mainfrom Jan 13, 2026
Merged
refactor: apply several optimizations#2notigorwastaken merged 16 commits intoOnBeat-Project:mainfrom
notigorwastaken merged 16 commits intoOnBeat-Project:mainfrom
Conversation
…filter presets all
update session_id
|
this is code |
Contributor
Author
|
yes, this is indeed code! |
Collaborator
|
Seeing these corrections made me realize I'm a terrible programmer lol |
notigorwastaken
approved these changes
Jan 13, 2026
Collaborator
notigorwastaken
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution, welcome to the team. 🥰
Contributor
Author
No, you are not! You are learning, Igor! To be honest, I would even say your Rust code is pretty good! ❤️ |
Contributor
Author
|
Just be sure to take note of my suggestions as you learn along! 😉 |
Collaborator
Absolutely, thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following pull request applies the following changes for optimization purposes:
crate::utils::emojis::get_emojiby making the second argument a&strnot aStringand making the function a one-liner.awaitseveral unused async callsformat!()and including removing some redundant onesclone()ing ofOption<T>types by usingas_ref()oras_deref()insteadclone()ing of types that implementCopyunwrap_or_default()whenever necessaryArc<T>sFilterPreset:ALLinstead of a method returns the sameVec<T>every timeequalizer_vec![]macro for every equalizer bands declaration instead of creating aVecand reconstructing it every timeSelf, marking some of them asconst, etc.)FromStrimpl to make outside code that use it cleanerFilters { ..., ..Default::default() }instead of manually modifying a manually createdFiltersstruct