Refactor discount and receipt systems using Strategy and Factory patterns#14
Draft
Refactor discount and receipt systems using Strategy and Factory patterns#14
Conversation
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor to apply suitable design patterns
Refactor discount and receipt systems using Strategy and Factory patterns
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the code organization and flexibility issues in the supermarket receipt system by implementing well-established design patterns across two key areas of the codebase.
Problem
The original codebase suffered from several code smells:
ShoppingCart.handleOffers()contained 40+ lines of complex conditional logicSolution
1. Strategy Pattern for Discount Calculations
Extracted the complex discount calculation logic from
ShoppingCart.handleOffers()into focused strategy classes:Concrete Strategies Implemented:
ThreeForTwoDiscountStrategyTenPercentDiscountStrategyTwoForAmountDiscountStrategyFiveForAmountDiscountStrategy2. Factory Pattern for Strategy Creation
DiscountStrategyFactorycentralizes the creation of discount strategies, eliminating conditional logic and making it easy to add new discount types.3. Strategy Pattern for Receipt Formatting
Implemented a flexible receipt formatting system that supports multiple output formats:
The
HtmlReceiptFormatterincludes proper HTML escaping and structured table output, addressing the HTML receipt feature request from the README.Results
Code Quality Improvements:
ShoppingCart.handleOffers()from 40+ lines to 16 linesFunctionality Enhancements:
Testing:
The refactoring demonstrates how multiple design patterns can work together to create a more maintainable, extensible, and robust codebase while preserving all existing functionality.
Fixes #7.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.