Extract hardcoded discount description strings to named constants#31
Draft
Extract hardcoded discount description strings to named constants#31
Conversation
…tions Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
… and C++ implementations Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
…atting Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Co-authored-by: nstubbe <20206435+nstubbe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor codebase to clean up magic strings
Extract hardcoded discount description strings to named constants
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded discount description strings (
"3 for 2","% off") were scattered throughout shopping cart implementations across 14 languages, violating DRY principles and complicating future changes.Changes
Extracted magic strings to named constants at the top of each
ShoppingCartimplementation:Before:
After:
Implementations Updated
Applied language-appropriate constant patterns across:
private static finalprivate constconst@)defconstantNotes
" % off"with leading space)"2 for X","5 for X") remain parameterized as they include variable amounts✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.