Diya fix(UI): Fixed People Report UI#4981
Open
DiyaWadhwani wants to merge 1 commit intodevelopmentfrom
Open
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two bugs on the People Report page: a visual artifact on the donut chart toggle, and incorrect hours calculation, causing the two pie charts to not sum to the Total Hours Logged.
Fixes # (medium) People Report page - toggle artifact + hours mismatch
Related PRS (if any):
None
Main changes explained:
UserProjectD3PieChart.jsxto remove the "Show percentage" label.selectors.jsxto fixprojectHourscalculation by skipping entries that have ataskId, preventing task hours from being double-counted in the projects pie chartselectors.jsxto fixhoursLoggedToProjectsOnlyto build fromprojectHoursdirectly instead of filtering throughuserProjects, so hours logged to projects the user was removed from are still shownselectors.jsxto resolve project names from the time entry'sprojectNamefield directly, fixing "Unknown Project" labels for projects no longer in the user's project listselectors.jsxto resolve task names from the time entry'sprojectNamefield as a fallback, fixing "Unnamed Task" labels for tasks without ataskNameon the entryHow to test:
npm installandnpm run start:localScreenshots or videos of changes:
Before:
After:
Note:
The hours mismatch was caused by two separate issues: task hours being double-counted in the projects chart, and projects the user was removed from being excluded entirely.
Both are now fixed. Reviewers should verify the sum of both pie chart totals matches the Total Hours Logged for multiple user profiles.