T8 #1594
Merged
T8 #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps org.eclipse.jetty.websocket:jetty-websocket-jetty-api from 12.1.4 to 12.1.5. --- updated-dependencies: - dependency-name: org.eclipse.jetty.websocket:jetty-websocket-jetty-api dependency-version: 12.1.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.eclipse.jetty:jetty-io from 12.1.3 to 12.1.5. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-io dependency-version: 12.1.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.eclipse.jetty.websocket:jetty-websocket-core-client from 12.1.4 to 12.1.5. --- updated-dependencies: - dependency-name: org.eclipse.jetty.websocket:jetty-websocket-core-client dependency-version: 12.1.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.eclipse.jetty:jetty-util from 12.1.4 to 12.1.5. --- updated-dependencies: - dependency-name: org.eclipse.jetty:jetty-util dependency-version: 12.1.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…jetty-jetty-util-12.1.5 Bump org.eclipse.jetty:jetty-util from 12.1.4 to 12.1.5
…jetty.websocket-jetty-websocket-core-client-12.1.5 Bump org.eclipse.jetty.websocket:jetty-websocket-core-client from 12.1.4 to 12.1.5
…jetty-jetty-io-12.1.5 Bump org.eclipse.jetty:jetty-io from 12.1.3 to 12.1.5
…jetty.websocket-jetty-websocket-jetty-api-12.1.5 Bump org.eclipse.jetty.websocket:jetty-websocket-jetty-api from 12.1.4 to 12.1.5
…in-mdtablesort.js Handle number sorting with units
…y and reliability
…-do-and-dov Add cancellation support to $do and $doV
nmaguiar
added
bug
enhancement
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces enhancements to asynchronous execution, table sorting, and Java version compatibility. The main changes include adding cancellation support to $do and $doV promises, improving table sorting for numeric values with units, updating dependencies, and adding Java 25 compatibility.
- Added
.cancel()method for$doand$doVpromises with comprehensive test coverage - Enhanced table sorting to handle numeric values with commas and various units (k, MB/s, etc.)
- Updated multiple dependencies (Rhino, Jetty, SNMP4J) to newer versions
- Added Java 25 JVM argument for compact object headers
Reviewed changes
Copilot reviewed 8 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/autoTestAll.Generic.yaml | Added test entries for $do and $doV cancellation |
| tests/autoTestAll.Generic.js | Implemented cancellation tests with atomic variables and timeouts |
| pom.xml | Updated Rhino (1.8.0→1.8.1), Jetty (12.1.3/12.1.4→12.1.5), and SNMP4J (3.8.2→3.8.3) |
| lib/*.jar | Binary library updates corresponding to pom.xml changes |
| js/mdtablesort.js | Added parseNumberWithUnits function and integrated into sort logic |
| js/genScripts.js | Added Java 25 argument -XX:+UseCompactObjectHeaders |
| docs/openaf-advanced.md | Updated documentation with cancellation feature and line references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features across the codebase, with a focus on enhancing asynchronous execution, table sorting, and Java version compatibility. The most significant changes include adding cancelation support to promises, improving table sorting for numeric values with units, and updating Java argument handling for newer versions.
Asynchronous Execution Enhancements
$doand$doVpromises: TheoPromiseclass now allows cancellation via a.cancel()method, which interrupts the associated thread and moves the promise into a rejected state. This is documented and implemented to mirror the behavior of the Threads plugin. [1] [2] [3] [4] [5] [6]Table Sorting Improvements
parseNumberWithUnitsfunction and integrating it into the sort logic. This improves user experience when sorting tables with mixed numeric and unit-based data. [1] [2]Java Version Compatibility
-XX:+UseCompactObjectHeaders) tojs/genScripts.jsand ensured it is included when generating scripts for Java 25 and above. [1] [2]Other Notable Changes
js/oafp.jsfrom"mtree"to"ctree".js/oafp.jsto20251213.These changes collectively improve the robustness and usability of asynchronous execution, data presentation, and platform compatibility.