Feature/storacha next #708
Conversation
Updated text for AddFolderScreen and CreateNewFolderScreen
…prefs_use_proofmode_description` string resource.
Bug fix/proofmode text changes
IA refactor to MVI from Redux CC License Setup Screen Compose Migration IA Detail Screen CC License Integration
SpaceList screen add btn size increased
…ds in crashlytics
removed space id arg from IALoginScreen, made IADetailScreen arg space_id as required
Feature/ia cc license
# Conflicts: # app/src/main/java/net/opendasharchive/openarchive/features/settings/SpaceSetupFragment.kt # app/src/main/res/navigation/space_setup_navigation.xml # gradle/libs.versions.toml
# Conflicts: # gradle/libs.versions.toml
There was a problem hiding this comment.
Pull Request Overview
This is a merge PR that brings the latest next branch changes into the feature/storacha branch. The changes primarily involve dependency version updates, UI improvements, code organization, and modernization of the Internet Archive and WebDAV functionality.
- Updates multiple library dependencies to newer versions
- Refactors Internet Archive and WebDAV flows to use Jetpack Navigation
- Improves UI layouts and text consistency across the app
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates library versions for core dependencies |
| app/src/main/res/xml/prefs_proof_mode.xml | Removes unused summary attribute from ProofMode preference |
| app/src/main/res/values/strings.xml | Improves text consistency and adds new license strings |
| app/src/main/res/navigation/space_setup_navigation.xml | Updates navigation structure for Internet Archive and license setup |
| app/src/main/res/layout/ | Various UI layout improvements and component reorganization |
| app/src/main/java/.../internetarchive/ | Refactors Internet Archive implementation to modern architecture |
| app/src/main/java/.../webdav/ | Modernizes WebDAV fragment implementation |
| app/src/main/java/.../settings/ | Adds new license setup functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| androidx-activity-compose = { group = "androidx.activity", name = "activity-compose", version.ref = "activity" } | ||
| androidx-activity-ktx = { group = "androidx.activity", name = "activity-ktx", version.ref = "activity" } | ||
| androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core-ktx" } | ||
| androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core" } |
There was a problem hiding this comment.
The version reference 'core' is used but there's no 'core' version defined in the [versions] section. This should reference 'core-ktx' instead.
| androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core" } | |
| androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version.ref = "core-ktx" } |
| android:layout_height="wrap_content" | ||
| android:layout_alignParentEnd="true" | ||
| android:checked="true" | ||
| android:checked="false" |
There was a problem hiding this comment.
The switch is set to checked='false' which changes the default behavior from the original checked='true'. This could affect existing user configurations and should be verified as intentional.
| val selectedSpace = state.selectedSpace | ||
|
|
||
| val folderName = selectedProject?.description | ||
| ?: selectedProject?.created.toString() |
There was a problem hiding this comment.
The nullable handling for selectedProject is inconsistent. Line 277 attempts to access selectedProject?.created after it's already been checked as nullable on line 276, but the null-safe call on created should use the same null-safe variable reference.
| ?: selectedProject?.created.toString() | |
| ?: "Unknown" |
| minSdk = 29 | ||
| targetSdk = 36 | ||
| versionCode = 30016 | ||
| versionCode = 30018 |
There was a problem hiding this comment.
[nitpick] Version code increment from 30016 to 30018 skips 30017, which may indicate missing version tracking or could cause issues with app update mechanisms.
| versionCode = 30018 | |
| versionCode = 30017 |
Merging latest
nextchanges intofeature/storacha